SML0127 commented on PR #3448: URL: https://github.com/apache/flink-cdc/pull/3448#issuecomment-2208534001
> Generally LGTM, but my concern is arbitrarily chosen columns can be risky, since chunking by columns without index is very slow. > > I think we need to update related documentations and address warnings about this. Looking forward to thoughts from @SML0127. After flink cdc v2.4.0, we allowed incremental snapshot to table without primary keys. [(https://nightlies.apache.org/flink/flink-cdc-docs-release-3.1/docs/connectors/flink-sources/mysql-cdc/)](https://nightlies.apache.org/flink/flink-cdc-docs-release-3.1/docs/connectors/flink-sources/mysql-cdc/#tables-without-primary-keys) So I think it is more natural to allow column as chunk key not in primary keys. But we also have to improve related documentations and address warnings. I will update documentations in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
