gyfora commented on code in PR #847:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/847#discussion_r1665850637
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java:
##########
@@ -95,9 +105,11 @@ public int computeScaleTargetParallelism(
LOG.warn(
"Target data rate is not available for {}, cannot compute
new parallelism",
vertex);
- return currentParallelism;
+ return VertexScalingResult.normalScaling(currentParallelism);
}
+ targetCapacity *= backpropagationScaleFactor;
Review Comment:
I think we should probably not trigger a scale down just based on an
identified bottleneck. We should use this logic to prevent scale ups, but
triggering a scale down may be a bit too aggressive, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
