RocMarshal commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1666472631
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java:
##########
@@ -82,6 +84,14 @@ public static AbstractJdbcCatalog createCatalog(
} else if (dialect instanceof MySqlDialect) {
return new MySqlCatalog(
userClassLoader, catalogName, defaultDatabase, baseUrl,
connectionProperties);
+ } else if (dialect instanceof OceanBaseDialect) {
Review Comment:
How about moving the creation of the xxxCatalog into the `JdbcDialect`, If
so, The code block `if... else ...` would be overwrited by `polymorphic` of
java ?
--> JdbcDialect.createCatalog(....)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
