gyfora commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1667256876
########## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkStateSnapshotStatus.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.api.status; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.kubernetes.operator.api.diff.Diffable; + +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import io.fabric8.crd.generator.annotation.PrinterColumn; +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.NoArgsConstructor; +import lombok.ToString; +import lombok.experimental.SuperBuilder; + +/** Last observed status of the Flink state snapshot. */ +@Experimental +@Data +@AllArgsConstructor +@NoArgsConstructor +@EqualsAndHashCode +@ToString Review Comment: see other comments ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java: ########## @@ -410,6 +430,14 @@ public static String operatorConfigKey(String key) { .withDescription( "Max number of reconcile loops triggered within the rate limiter refresh period for each resource. Setting the limit <= 0 disables the limiter."); + @Documentation.Section(SECTION_DYNAMIC) + public static final ConfigOption<Boolean> OPERATOR_JOB_UPGRADE_SAVEPOINT_DISPOSE_ON_DELETE = + operatorConfig("job.upgrade.savepoint.dispose-on-delete") + .booleanType() + .defaultValue(false) + .withDescription( + "Savepoint data created by upgrade savepoints as FlinkStateSnapshot resources will be disposed of automatically when the Kubernetes resource gets deleted."); + Review Comment: I think we should have a single dispose-on-delete config that generally applies to snapshot resources. ########## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/spec/FlinkStateSnapshotSpec.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.api.spec; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.kubernetes.operator.api.diff.Diffable; + +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.NoArgsConstructor; +import lombok.ToString; +import lombok.experimental.SuperBuilder; + +/** Spec that describes a FlinkStateSnapshot. */ +@Experimental +@Data +@NoArgsConstructor +@AllArgsConstructor +@EqualsAndHashCode +@ToString Review Comment: Data covers equals and toString ########## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/spec/CheckpointSpec.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.api.spec; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.kubernetes.operator.api.status.CheckpointType; + +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import lombok.AllArgsConstructor; +import lombok.Builder; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.NoArgsConstructor; + +/** Spec for checkpoint state snapshots. */ +@Experimental +@Data +@NoArgsConstructor +@AllArgsConstructor +@Builder +@EqualsAndHashCode Review Comment: `@Data` already adds EqualsAndHashCode, you probably copied this from other classes (so maybe I messed up first :D) but it should not be necessary ########## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/CommonStatus.java: ########## @@ -27,11 +27,13 @@ import io.fabric8.crd.generator.annotation.PrinterColumn; import lombok.AllArgsConstructor; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.NoArgsConstructor; import lombok.experimental.SuperBuilder; import org.apache.commons.lang3.StringUtils; /** Last observed common status of the Flink deployment/Flink SessionJob. */ +@EqualsAndHashCode Review Comment: Data should cover this, did you hit some issue without it? ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/snapshot/StateSnapshotObserver.java: ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.observer.snapshot; + +import org.apache.flink.autoscaler.utils.DateTimeUtils; +import org.apache.flink.kubernetes.operator.api.FlinkDeployment; +import org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot; +import org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotState; +import org.apache.flink.kubernetes.operator.controller.FlinkResourceContext; +import org.apache.flink.kubernetes.operator.controller.FlinkStateSnapshotContext; +import org.apache.flink.kubernetes.operator.observer.CheckpointFetchResult; +import org.apache.flink.kubernetes.operator.observer.SavepointFetchResult; +import org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils; +import org.apache.flink.kubernetes.operator.service.FlinkResourceContextFactory; +import org.apache.flink.kubernetes.operator.utils.EventRecorder; + +import io.fabric8.kubernetes.client.KubernetesClient; +import lombok.RequiredArgsConstructor; +import org.apache.commons.lang3.StringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.time.Instant; + +/** The observer of {@link org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot}. */ +@RequiredArgsConstructor +public class StateSnapshotObserver { + + private static final Logger LOG = LoggerFactory.getLogger(StateSnapshotObserver.class); + + private final FlinkResourceContextFactory ctxFactory; + private final EventRecorder eventRecorder; + + public void observe(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var savepointState = resource.getStatus().getState(); + + if (FlinkStateSnapshotState.IN_PROGRESS.equals(savepointState)) { + observeSavepointState(ctx); + } + } + + private void observeSavepointState(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + var triggerId = resource.getStatus().getTriggerId(); + + LOG.info("Observing savepoint state for resource {}...", resourceName); + + if (StringUtils.isEmpty(triggerId)) { + LOG.debug("Trigger ID is not set for savepoint {} yet.", resourceName); Review Comment: we could remove this and move the Observing log after the if? ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/snapshot/StateSnapshotObserver.java: ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.observer.snapshot; + +import org.apache.flink.autoscaler.utils.DateTimeUtils; +import org.apache.flink.kubernetes.operator.api.FlinkDeployment; +import org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot; +import org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotState; +import org.apache.flink.kubernetes.operator.controller.FlinkResourceContext; +import org.apache.flink.kubernetes.operator.controller.FlinkStateSnapshotContext; +import org.apache.flink.kubernetes.operator.observer.CheckpointFetchResult; +import org.apache.flink.kubernetes.operator.observer.SavepointFetchResult; +import org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils; +import org.apache.flink.kubernetes.operator.service.FlinkResourceContextFactory; +import org.apache.flink.kubernetes.operator.utils.EventRecorder; + +import io.fabric8.kubernetes.client.KubernetesClient; +import lombok.RequiredArgsConstructor; +import org.apache.commons.lang3.StringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.time.Instant; + +/** The observer of {@link org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot}. */ +@RequiredArgsConstructor +public class StateSnapshotObserver { + + private static final Logger LOG = LoggerFactory.getLogger(StateSnapshotObserver.class); + + private final FlinkResourceContextFactory ctxFactory; + private final EventRecorder eventRecorder; + + public void observe(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var savepointState = resource.getStatus().getState(); + + if (FlinkStateSnapshotState.IN_PROGRESS.equals(savepointState)) { + observeSavepointState(ctx); + } + } + + private void observeSavepointState(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + var triggerId = resource.getStatus().getTriggerId(); + + LOG.info("Observing savepoint state for resource {}...", resourceName); Review Comment: This should be debug ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/snapshot/StateSnapshotObserver.java: ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.observer.snapshot; + +import org.apache.flink.autoscaler.utils.DateTimeUtils; +import org.apache.flink.kubernetes.operator.api.FlinkDeployment; +import org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot; +import org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotState; +import org.apache.flink.kubernetes.operator.controller.FlinkResourceContext; +import org.apache.flink.kubernetes.operator.controller.FlinkStateSnapshotContext; +import org.apache.flink.kubernetes.operator.observer.CheckpointFetchResult; +import org.apache.flink.kubernetes.operator.observer.SavepointFetchResult; +import org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils; +import org.apache.flink.kubernetes.operator.service.FlinkResourceContextFactory; +import org.apache.flink.kubernetes.operator.utils.EventRecorder; + +import io.fabric8.kubernetes.client.KubernetesClient; +import lombok.RequiredArgsConstructor; +import org.apache.commons.lang3.StringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.time.Instant; + +/** The observer of {@link org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot}. */ +@RequiredArgsConstructor +public class StateSnapshotObserver { + + private static final Logger LOG = LoggerFactory.getLogger(StateSnapshotObserver.class); + + private final FlinkResourceContextFactory ctxFactory; + private final EventRecorder eventRecorder; + + public void observe(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var savepointState = resource.getStatus().getState(); + + if (FlinkStateSnapshotState.IN_PROGRESS.equals(savepointState)) { + observeSavepointState(ctx); + } + } + + private void observeSavepointState(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + var triggerId = resource.getStatus().getTriggerId(); + + LOG.info("Observing savepoint state for resource {}...", resourceName); + + if (StringUtils.isEmpty(triggerId)) { + LOG.debug("Trigger ID is not set for savepoint {} yet.", resourceName); + return; + } + + var secondaryResource = + ctx.getSecondaryResource() + .orElseThrow( + () -> + new RuntimeException( + String.format( + "Secondary resource %s for savepoint %s was not found", + resource.getSpec().getJobReference(), + resourceName))); + var jobId = secondaryResource.getStatus().getJobStatus().getJobId(); + + var ctxFlinkDeployment = + ctxFactory.getResourceContext( + ctx.getReferencedJobFlinkDeployment(), ctx.getJosdkContext()); + var observeConfig = ctx.getReferencedJobObserveConfig(); + + if (!ReconciliationUtils.isJobRunning(secondaryResource.getStatus())) { + snapshotAbandoned(resource); + return; + } + + if (resource.getSpec().isSavepoint()) { + var savepointInfo = + ctxFlinkDeployment + .getFlinkService() + .fetchSavepointInfo(triggerId, jobId, observeConfig); + handleSavepoint(ctx, savepointInfo); + } else { + var checkpointInfo = + ctxFlinkDeployment + .getFlinkService() + .fetchCheckpointInfo(triggerId, jobId, observeConfig); + handleCheckpoint(ctx, checkpointInfo, ctxFlinkDeployment, jobId); + } + } + + private void handleSavepoint( + FlinkStateSnapshotContext ctx, SavepointFetchResult savepointInfo) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + + if (savepointInfo.isPending()) { + LOG.debug( + "Savepoint '{}' with ID {} is pending", + resourceName, + resource.getStatus().getTriggerId()); + } else if (savepointInfo.getError() != null) { + LOG.error("Savepoint {} failed: {}", resourceName, savepointInfo.getError()); Review Comment: Unnecessary as there is an event for this already ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/snapshot/StateSnapshotObserver.java: ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.observer.snapshot; + +import org.apache.flink.autoscaler.utils.DateTimeUtils; +import org.apache.flink.kubernetes.operator.api.FlinkDeployment; +import org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot; +import org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotState; +import org.apache.flink.kubernetes.operator.controller.FlinkResourceContext; +import org.apache.flink.kubernetes.operator.controller.FlinkStateSnapshotContext; +import org.apache.flink.kubernetes.operator.observer.CheckpointFetchResult; +import org.apache.flink.kubernetes.operator.observer.SavepointFetchResult; +import org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils; +import org.apache.flink.kubernetes.operator.service.FlinkResourceContextFactory; +import org.apache.flink.kubernetes.operator.utils.EventRecorder; + +import io.fabric8.kubernetes.client.KubernetesClient; +import lombok.RequiredArgsConstructor; +import org.apache.commons.lang3.StringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.time.Instant; + +/** The observer of {@link org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot}. */ +@RequiredArgsConstructor +public class StateSnapshotObserver { + + private static final Logger LOG = LoggerFactory.getLogger(StateSnapshotObserver.class); + + private final FlinkResourceContextFactory ctxFactory; + private final EventRecorder eventRecorder; + + public void observe(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var savepointState = resource.getStatus().getState(); + + if (FlinkStateSnapshotState.IN_PROGRESS.equals(savepointState)) { + observeSavepointState(ctx); + } + } + + private void observeSavepointState(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + var triggerId = resource.getStatus().getTriggerId(); + + LOG.info("Observing savepoint state for resource {}...", resourceName); + + if (StringUtils.isEmpty(triggerId)) { + LOG.debug("Trigger ID is not set for savepoint {} yet.", resourceName); + return; + } + + var secondaryResource = + ctx.getSecondaryResource() + .orElseThrow( + () -> + new RuntimeException( + String.format( + "Secondary resource %s for savepoint %s was not found", + resource.getSpec().getJobReference(), + resourceName))); + var jobId = secondaryResource.getStatus().getJobStatus().getJobId(); + + var ctxFlinkDeployment = + ctxFactory.getResourceContext( + ctx.getReferencedJobFlinkDeployment(), ctx.getJosdkContext()); + var observeConfig = ctx.getReferencedJobObserveConfig(); + + if (!ReconciliationUtils.isJobRunning(secondaryResource.getStatus())) { + snapshotAbandoned(resource); + return; + } + + if (resource.getSpec().isSavepoint()) { + var savepointInfo = + ctxFlinkDeployment + .getFlinkService() + .fetchSavepointInfo(triggerId, jobId, observeConfig); + handleSavepoint(ctx, savepointInfo); + } else { + var checkpointInfo = + ctxFlinkDeployment + .getFlinkService() + .fetchCheckpointInfo(triggerId, jobId, observeConfig); + handleCheckpoint(ctx, checkpointInfo, ctxFlinkDeployment, jobId); + } + } + + private void handleSavepoint( + FlinkStateSnapshotContext ctx, SavepointFetchResult savepointInfo) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + + if (savepointInfo.isPending()) { + LOG.debug( + "Savepoint '{}' with ID {} is pending", + resourceName, + resource.getStatus().getTriggerId()); + } else if (savepointInfo.getError() != null) { + LOG.error("Savepoint {} failed: {}", resourceName, savepointInfo.getError()); + snapshotFailed(ctx.getKubernetesClient(), resource, savepointInfo.getError()); + } else { + LOG.info("Savepoint {} successful: {}", resourceName, savepointInfo.getLocation()); + snapshotSuccessful(resource, savepointInfo.getLocation()); + } + } + + private void handleCheckpoint( + FlinkStateSnapshotContext ctx, + CheckpointFetchResult checkpointInfo, + FlinkResourceContext<FlinkDeployment> ctxFlinkDeployment, + String jobId) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + + if (checkpointInfo.isPending()) { + LOG.debug( + "Checkpoint for {} with ID {} is pending", + resourceName, + resource.getStatus().getTriggerId()); + return; + } + + if (checkpointInfo.getError() != null) { + LOG.error("Checkpoint {} failed: {}", resourceName, checkpointInfo.getError()); + snapshotFailed(ctx.getKubernetesClient(), resource, checkpointInfo.getError()); + } else { + LOG.info( + "Checkpoint {} was successful, querying final checkpoint path...", + resourceName); Review Comment: I think this could be debug or removed ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/snapshot/StateSnapshotObserver.java: ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.observer.snapshot; + +import org.apache.flink.autoscaler.utils.DateTimeUtils; +import org.apache.flink.kubernetes.operator.api.FlinkDeployment; +import org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot; +import org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotState; +import org.apache.flink.kubernetes.operator.controller.FlinkResourceContext; +import org.apache.flink.kubernetes.operator.controller.FlinkStateSnapshotContext; +import org.apache.flink.kubernetes.operator.observer.CheckpointFetchResult; +import org.apache.flink.kubernetes.operator.observer.SavepointFetchResult; +import org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils; +import org.apache.flink.kubernetes.operator.service.FlinkResourceContextFactory; +import org.apache.flink.kubernetes.operator.utils.EventRecorder; + +import io.fabric8.kubernetes.client.KubernetesClient; +import lombok.RequiredArgsConstructor; +import org.apache.commons.lang3.StringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.time.Instant; + +/** The observer of {@link org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot}. */ +@RequiredArgsConstructor +public class StateSnapshotObserver { + + private static final Logger LOG = LoggerFactory.getLogger(StateSnapshotObserver.class); + + private final FlinkResourceContextFactory ctxFactory; + private final EventRecorder eventRecorder; + + public void observe(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var savepointState = resource.getStatus().getState(); + + if (FlinkStateSnapshotState.IN_PROGRESS.equals(savepointState)) { + observeSavepointState(ctx); + } + } + + private void observeSavepointState(FlinkStateSnapshotContext ctx) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + var triggerId = resource.getStatus().getTriggerId(); + + LOG.info("Observing savepoint state for resource {}...", resourceName); + + if (StringUtils.isEmpty(triggerId)) { + LOG.debug("Trigger ID is not set for savepoint {} yet.", resourceName); + return; + } + + var secondaryResource = + ctx.getSecondaryResource() + .orElseThrow( + () -> + new RuntimeException( + String.format( + "Secondary resource %s for savepoint %s was not found", + resource.getSpec().getJobReference(), + resourceName))); + var jobId = secondaryResource.getStatus().getJobStatus().getJobId(); + + var ctxFlinkDeployment = + ctxFactory.getResourceContext( + ctx.getReferencedJobFlinkDeployment(), ctx.getJosdkContext()); + var observeConfig = ctx.getReferencedJobObserveConfig(); + + if (!ReconciliationUtils.isJobRunning(secondaryResource.getStatus())) { + snapshotAbandoned(resource); + return; + } + + if (resource.getSpec().isSavepoint()) { + var savepointInfo = + ctxFlinkDeployment + .getFlinkService() + .fetchSavepointInfo(triggerId, jobId, observeConfig); + handleSavepoint(ctx, savepointInfo); + } else { + var checkpointInfo = + ctxFlinkDeployment + .getFlinkService() + .fetchCheckpointInfo(triggerId, jobId, observeConfig); + handleCheckpoint(ctx, checkpointInfo, ctxFlinkDeployment, jobId); + } + } + + private void handleSavepoint( + FlinkStateSnapshotContext ctx, SavepointFetchResult savepointInfo) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + + if (savepointInfo.isPending()) { + LOG.debug( + "Savepoint '{}' with ID {} is pending", + resourceName, + resource.getStatus().getTriggerId()); + } else if (savepointInfo.getError() != null) { + LOG.error("Savepoint {} failed: {}", resourceName, savepointInfo.getError()); + snapshotFailed(ctx.getKubernetesClient(), resource, savepointInfo.getError()); + } else { + LOG.info("Savepoint {} successful: {}", resourceName, savepointInfo.getLocation()); + snapshotSuccessful(resource, savepointInfo.getLocation()); + } + } + + private void handleCheckpoint( + FlinkStateSnapshotContext ctx, + CheckpointFetchResult checkpointInfo, + FlinkResourceContext<FlinkDeployment> ctxFlinkDeployment, + String jobId) { + var resource = ctx.getResource(); + var resourceName = resource.getMetadata().getName(); + + if (checkpointInfo.isPending()) { + LOG.debug( + "Checkpoint for {} with ID {} is pending", + resourceName, + resource.getStatus().getTriggerId()); + return; + } + + if (checkpointInfo.getError() != null) { + LOG.error("Checkpoint {} failed: {}", resourceName, checkpointInfo.getError()); Review Comment: Unnecessary as we trigger an event which logs this again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
