[ 
https://issues.apache.org/jira/browse/FLINK-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708017#comment-15708017
 ] 

ASF GitHub Bot commented on FLINK-5190:
---------------------------------------

GitHub user shuai-xu opened a pull request:

    https://github.com/apache/flink/pull/2905

    [FLINK-5190] [runtime] fix ZooKeeperLeaderRetrievalService close the …

    This pr is for jira 
#[5190](https://issues.apache.org/jira/browse/FLINK-5190).
    
    The zk client for ZooKeeperLeaderRetrievalService is pass from outside, if 
closing the zk client when stop, will influence others who want to use the zk 
client.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuai-xu/flink jira-5190

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2905.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2905
    
----
commit de27b4c995c2ce0125ce62738c5bf8c38c02673b
Author: shuai.xus <shuai....@alibaba-inc.com>
Date:   2016-11-30T09:02:49Z

    [FLINK-5190] [runtime] fix ZooKeeperLeaderRetrievalService close the zk 
client when stopping bug

----


> ZooKeeperLeaderRetrievalService should not close the zk client when stop
> ------------------------------------------------------------------------
>
>                 Key: FLINK-5190
>                 URL: https://issues.apache.org/jira/browse/FLINK-5190
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> The zk client is created outside of ZooKeeperLeaderRetrievalService and 
> psssed to it, when ZooKeeperLeaderRetrievalService stop, it should not stop 
> the zk client as other may be using it outside.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to