hlteoh37 commented on code in PR #148:
URL:
https://github.com/apache/flink-connector-aws/pull/148#discussion_r1674144962
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/PollingKinesisShardSplitReader.java:
##########
@@ -127,6 +137,14 @@ public void
handleSplitsChanges(SplitsChange<KinesisShardSplit> splitsChanges) {
}
}
+ @Override
+ public void pauseOrResumeSplits(
+ Collection<KinesisShardSplit> splitsToPause,
+ Collection<KinesisShardSplit> splitsToResume) {
+ splitsToPause.forEach(split -> pausedSplitIds.add(split.splitId()));
+ splitsToResume.forEach(split ->
pausedSplitIds.remove(split.splitId()));
Review Comment:
Do we need to check and log if we resume a split that is not paused / pause
a split that doesn't exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
