snuyanzin commented on code in PR #25076:
URL: https://github.com/apache/flink/pull/25076#discussion_r1674178015
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -433,7 +433,7 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
public static final BuiltInFunctionDefinition URL_DECODE =
BuiltInFunctionDefinition.newBuilder()
- .name("url_decode")
+ .name("URL_DECODE")
.kind(SCALAR)
.inputTypeStrategy(sequence(logical(LogicalTypeFamily.CHARACTER_STRING)))
.outputTypeStrategy(nullableIfArgs(explicit(DataTypes.STRING().nullable())))
Review Comment:
@lincoln-lil thanks for the feedback
now I see what you mean
Yep, it makes, thanks for clarification
I updated the PR to address this, could you please approve/reject?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
