SML0127 commented on code in PR #3456:
URL: https://github.com/apache/flink-cdc/pull/3456#discussion_r1675526967
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/metrics/MySqlSourceReaderMetrics.java:
##########
@@ -17,18 +17,37 @@
package org.apache.flink.cdc.connectors.mysql.source.metrics;
+import org.apache.flink.cdc.common.event.OperationType;
import org.apache.flink.cdc.connectors.mysql.source.reader.MySqlSourceReader;
+import org.apache.flink.metrics.Counter;
import org.apache.flink.metrics.Gauge;
import org.apache.flink.metrics.MetricGroup;
import org.apache.flink.runtime.metrics.MetricNames;
+import io.debezium.relational.TableId;
+
+import java.util.concurrent.ConcurrentHashMap;
+
/** A collection class for handling metrics in {@link MySqlSourceReader}. */
public class MySqlSourceReaderMetrics {
public static final long UNDEFINED = -1;
private final MetricGroup metricGroup;
+ public static final String IO_NUM_RECORDS_OUT_SNAPSHOT =
".numRecordsOutBySnapshot";
+
+ public static final String IO_NUM_RECORDS_OUT_INCREMENTAL_INSERT =
+ ".numRecordsOutByIncrementalInsert";
+
+ public static final String IO_NUM_RECORDS_OUT_INCREMENTAL_DELETE =
+ ".numRecordsOutByIncrementalDelete";
+
+ public static final String IO_NUM_RECORDS_OUT_INCREMENTAL_UPDATE =
+ ".numRecordsOutByIncrementalUpdate";
Review Comment:
Thx for contirbution @ChengJie1053
Nit: How about changing `INCREMENTAL` to `BINLOG` or `CHANGE_EVENT`?
`INCREMENTAL` can be understood as a `Incremental Snapshot` step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
