davidradl commented on code in PR #24835:
URL: https://github.com/apache/flink/pull/24835#discussion_r1675721067
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java:
##########
@@ -242,21 +249,33 @@ public <T> HiveSource<T>
buildWithBulkFormat(BulkFormat<T, HiveSourceSplit> bulk
hiveTablePartitionBytes =
HivePartitionUtils.serializeHiveTablePartition(partitions);
}
- return new HiveSource<>(
- new Path[1],
- new HiveSourceFileEnumerator.Provider(
- hiveTablePartitionBytes, new JobConfWrapper(jobConf)),
- splitAssigner,
- bulkFormat,
- continuousSourceSettings,
- jobConf,
- tablePath,
- partitionKeys,
- hiveVersion,
- dynamicFilterPartitionKeys,
- hiveTablePartitionBytes,
- fetcher,
- fetcherContext);
+ DefaultSourceLineageVertex vertex =
Review Comment:
I like the idea of adding a default source vertex and a default vertex. I
wonder if there are any Hive specifics we could add to the vertex that would
warrant not using the default. Maybe the type of table, e.g. Hive or Iceberg
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
