[ 
https://issues.apache.org/jira/browse/FLINK-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709567#comment-15709567
 ] 

ASF GitHub Bot commented on FLINK-5069:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2809#discussion_r90306783
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/stats/PendingCheckpointStats.java
 ---
    @@ -0,0 +1,187 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.checkpoint.stats;
    +
    +import org.apache.flink.runtime.jobgraph.JobVertexID;
    +
    +import java.io.Serializable;
    +import java.util.Iterator;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +import java.util.Set;
    +
    +/**
    + * Statistics for a pending checkpoint.
    + */
    +public class PendingCheckpointStats implements Serializable {
    --- End diff --
    
    Can this be refactored into `org.apache.flink.runtime.metrics.groups`?


> Pending checkpoint statistics gauge
> -----------------------------------
>
>                 Key: FLINK-5069
>                 URL: https://issues.apache.org/jira/browse/FLINK-5069
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: zhuhaifeng
>            Assignee: zhuhaifeng
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Add the statistics of pending checkpoints as a gauge metric. When the 
> checkpoint appears not to be completed, this metric would  help to get the 
> state of a pending checkpoint , e.g  which task did not complete the 
> checkpoint. 
> The statistic will be as the follows:
> checkpointID, 
> Number Of Acknowledged Tasks,
> Number Of Not yet Acknowledged Tasks, 
> The detail of not yet acknowledged JobVertexID, taskID



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to