yuxiqian commented on code in PR #3385:
URL: https://github.com/apache/flink-cdc/pull/3385#discussion_r1679027291
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/converters/MysqlDebeziumTimeConverter.java:
##########
@@ -61,7 +61,11 @@ public class MysqlDebeziumTimeConverter
private static boolean loggedUnknownTimeClass = false;
private static boolean loggedUnknownTimestampWithTimeZoneClass = false;
- private final String[] DATE_TYPES = {"DATE", "DATETIME", "TIME",
"TIMESTAMP"};
+ private static final String DATE = "DATE";
+ private static final String DATETIME = "DATETIME";
+ private static final String TIME = "TIME";
+ private static final String TIMESTAMP = "TIMESTAMP";
+ private final String[] DATE_TYPES = {DATE, DATETIME, TIME, TIMESTAMP};
Review Comment:
Sorry, I was thinking if `DATA_TYPES` could be `static` too, since they're
not instance specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
