Re: [PR] [cdc-connector][oracle] OracleSchema getTableSchema Description Modified [flink-cdc]

Tue, 16 Jul 2024 04:27:49 -0700 


ChengJie1053 commented on code in PR #3443:
URL: https://github.com/apache/flink-cdc/pull/3443#discussion_r1679226654


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/main/java/org/apache/flink/cdc/connectors/oracle/source/utils/OracleSchema.java:
##########
@@ -42,10 +42,7 @@ public OracleSchema() {
         this.schemasByTableId = new HashMap<>();
     }
 
-    /**
-     * Gets table schema for the given table path. It will request to MySQL 
server by running `SHOW
-     * CREATE TABLE` if cache missed.
-     */
+    /** Gets table schema for the given table path. It will request to Oracle 
server by running */

Review Comment:
   
![image](https://github.com/user-attachments/assets/bdd9f29a-6d65-458d-8c97-ddd30ba85f5b)
   
   
![image](https://github.com/user-attachments/assets/e69a904e-ef54-48dd-96ed-4dd2997d12db)
   
   It is complete, because I found that it was not obtained by executing sql, 
it was obtained by java.sql.connect #getMetaData



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to