yuxiqian commented on code in PR #3443:
URL: https://github.com/apache/flink-cdc/pull/3443#discussion_r1679231485
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/main/java/org/apache/flink/cdc/connectors/oracle/source/utils/OracleSchema.java:
##########
@@ -42,10 +42,7 @@ public OracleSchema() {
this.schemasByTableId = new HashMap<>();
}
- /**
- * Gets table schema for the given table path. It will request to MySQL
server by running `SHOW
- * CREATE TABLE` if cache missed.
- */
+ /** Gets table schema for the given table path. It will request to Oracle
server by running */
Review Comment:
~~Since there's no server request at all, what about removing `It will
request to Oracle server by running`?~~
> Or is it ok if I change it to this
Sorry I missed your reply, I think you're right on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
