[
https://issues.apache.org/jira/browse/FLINK-35851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866603#comment-17866603
]
Rui Fan commented on FLINK-35851:
---------------------------------
I load the config from main parameters for 2 reasons:
* Autoscaler standalone only provides the jar for users
** We didn't provide a bin or dist directory, so it's not easy to bind the
config.yaml as well
* Loading the config from main parameters is easy to quick start or test
However, loading config from config file sounds make sense to me, it's useful
for managing the configurations.
Actually, our internal autoscaler standalone service load config from config
file, but our file name is flink-autoscaler.yaml instead of flink-conf.yaml or
config.yaml. GlobalConfiguration.loadConfiguration only supports
flink-conf.yaml or config.yaml, that's why I didn't feedback it to community.
But from community perspective, I think GlobalConfiguration.loadConfiguration
is fine.
Also, how about Autoscaler standalone support load config from config file and
main parameters together? And main parameters will overwrite the config file if
one option is set at 2 sides.
I propose it for 2 reasons:
* GlobalConfiguration.loadConfiguration only load config if FLINK_CONF_DIR is
set, and FLINK_CONF_DIR isn't set by default.
** Autoscaler standalone only provides the jar for users, so we are unable to
enable it by default.
* Loading the config from main parameters is easy to quick start
WDYT?
> autoscaler standlone mode use `GlobalConfiguration.loadConfiguration` load
> config
> ---------------------------------------------------------------------------------
>
> Key: FLINK-35851
> URL: https://issues.apache.org/jira/browse/FLINK-35851
> Project: Flink
> Issue Type: Improvement
> Components: Autoscaler
> Reporter: yuanfenghu
> Priority: Minor
>
> We should use GlobalConfiguration.loadConfiguration to load the autocaler
> configuration and keep it consistent with other components
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
