mxm commented on code in PR #847:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/847#discussion_r1680664844
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java:
##########
@@ -150,6 +155,122 @@ public int computeScaleTargetParallelism(
return newParallelism;
}
+ public boolean propagateBackpropScaleFactor(
+ Configuration conf,
+ JobVertexID vertex,
+ JobTopology topology,
+ EvaluatedMetrics evaluatedMetrics,
+ Map<JobVertexID, Double> backpropScaleFactors,
+ List<String> excludedVertices) {
+
+ double averageTrueProcessingRate =
+ evaluatedMetrics
+ .getVertexMetrics()
+ .get(vertex)
+ .get(TRUE_PROCESSING_RATE)
+ .getAverage();
Review Comment:
Why is this metric required? Isn't the `TARGET_DATA_RATE` the relevant
metric sufficinet to apply the backpropagation factor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
