1996fanrui commented on code in PR #853:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/853#discussion_r1682109072
##########
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerEntrypoint.java:
##########
@@ -48,7 +49,9 @@ public class StandaloneAutoscalerEntrypoint {
public static <KEY, Context extends JobAutoScalerContext<KEY>> void
main(String[] args)
throws Exception {
- var conf = ParameterTool.fromArgs(args).getConfiguration();
+ var conf =
+ GlobalConfiguration.loadConfiguration(
+ ParameterTool.fromArgs(args).getConfiguration());
Review Comment:
Would you mind extracting this part as a separate method and adding a unit
test?
Separate method is helpful for adding a unit test to check whether overwrite
logic is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
