shiyiky commented on code in PR #3432:
URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1687363640
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java:
##########
@@ -240,12 +240,15 @@ private static Map<String, String> querySystemVariables(
return variables;
}
- public static BinlogOffset findBinlogOffset(long targetMs, MySqlConnection
connection) {
+ public static BinlogOffset findBinlogOffset(
+ long targetMs, MySqlConnection connection, MySqlSourceConfig
mySqlSourceConfig) {
Review Comment:
At first, I did think so, but considering that this is a method inside the
util attribute, there may be some changes later, and the attributes carried by
the config class will create more in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
