gyfora commented on code in PR #855:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/855#discussion_r1688196270
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -289,6 +289,8 @@ public boolean
reconcileOtherChanges(FlinkResourceContext<CR> ctx) throws Except
LOG.info("Stopping failed Flink job...");
cleanupAfterFailedJob(ctx);
status.setError(null);
+ ReconciliationUtils.updateStatusForDeployedSpec(
+ ctx.getResource(),
ctx.getDeployConfig(ctx.getResource().getSpec()), clock);
Review Comment:
Hm I see, I think you are right. I think the more straightforward and
simpler fix would be to actually fix the `resubmitJob` method. In case where we
have a savepoint it should set the upgradeMode to savepoint on the spec to
recover. Otherwise it can leave it stateless. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
