19priyadhingra commented on code in PR #141:
URL:
https://github.com/apache/flink-connector-aws/pull/141#discussion_r1688281873
##########
flink-connector-aws/flink-connector-sqs/src/test/java/org/apache/flink/connector/sqs/sink/SqsSinkBuilderTest.java:
##########
@@ -25,14 +25,6 @@
/** Covers construction, defaults and sanity checking of {@link
SqsSinkBuilder}. */
class SqsSinkBuilderTest {
- @Test
- void elementConverterOfSinkMustBeSetWhenBuilt() {
- Assertions.assertThatExceptionOfType(NullPointerException.class)
- .isThrownBy(() ->
SqsSink.builder().setSqsUrl("sqlUrl").build())
- .withMessageContaining(
- "No SerializationSchema was supplied to the SQS Sink
builder.");
- }
-
Review Comment:
because we added a default SerializationSchema if it is not provided by the
customer so we never end up throwing this error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
