RocMarshal commented on code in PR #25113:
URL: https://github.com/apache/flink/pull/25113#discussion_r1689424572
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##########
@@ -1115,6 +1116,11 @@ public CompletableFuture<Acknowledge>
updateJobResourceRequirements(
return CompletableFuture.completedFuture(Acknowledge.get());
}
+ @VisibleForTesting
+ public SlotPoolService getSlotPoolService() {
Review Comment:
Thanks for the commet.
It's a pure redundant test case.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##########
@@ -1115,6 +1116,11 @@ public CompletableFuture<Acknowledge>
updateJobResourceRequirements(
return CompletableFuture.completedFuture(Acknowledge.get());
}
+ @VisibleForTesting
+ public SlotPoolService getSlotPoolService() {
Review Comment:
Thanks for the comment.
It's a pure redundant test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
