yuxiqian commented on code in PR #3357:
URL: https://github.com/apache/flink-cdc/pull/3357#discussion_r1689894811


##########
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/transform/TransformDataOperatorTest.java:
##########
@@ -555,6 +574,64 @@ void testTimestampDiffTransform() throws Exception {
                 .isEqualTo(new StreamRecord<>(insertEventExpect));
     }
 
+    @Test
+    void testNullCastTransform() throws Exception {

Review Comment:
   Great to see this! Could you please insert more non-null data row to test if 
non-null value casting and verify if casting results are correct? Maybe 
`FlinkPipelineComposerITCase` is a good place for this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to