1996fanrui commented on code in PR #856:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/856#discussion_r1693165793
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/realizer/ScalingRealizer.java:
##########
@@ -33,8 +33,13 @@
@Experimental
public interface ScalingRealizer<KEY, Context extends
JobAutoScalerContext<KEY>> {
- /** Update job's parallelism to parallelismOverrides. */
- void realizeParallelismOverrides(Context context, Map<String, String>
parallelismOverrides);
+ /**
+ * Update job's parallelism to parallelismOverrides.
+ *
+ * @throws Exception Error during realize parallelism overrides.
+ */
+ void realizeParallelismOverrides(Context context, Map<String, String>
parallelismOverrides)
+ throws Exception;
/** Updates the TaskManager memory configuration. */
void realizeConfigOverrides(Context context, ConfigChanges configChanges);
Review Comment:
I'm thinking should these 2 methods keep same semantic? Such as: assert `
throws Exception` together.
It's a little wired: one throws, one not.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
