eskabetxe commented on code in PR #134:
URL:
https://github.com/apache/flink-connector-jdbc/pull/134#discussion_r1698468013
##########
flink-connector-jdbc-core/src/test/java/org/apache/flink/connector/jdbc/core/table/source/JdbcFilterPushdownPreparedStatementVisitorTest.java:
##########
@@ -294,4 +294,40 @@ private List<ResolvedExpression>
resolveSQLFilterToExpression(
return resolver.resolve(Arrays.asList(resolvedExp));
}
+
+ private RexNodeToExpressionConverter getConverter(
+ RexBuilder rexBuilder,
+ String[] inputNames,
+ FunctionCatalog functionCatalog,
+ CatalogManager catalogManager) {
+ try {
+ Class<?> clazz =
+ Class.forName(
+
"org.apache.flink.table.planner.plan.utils.RexNodeToExpressionConverter",
Review Comment:
```suggestion
RexNodeToExpressionConverter.class.getCanonicalName(),
```
##########
flink-connector-jdbc-core/src/test/java/org/apache/flink/connector/jdbc/core/table/source/JdbcFilterPushdownPreparedStatementVisitorTest.java:
##########
@@ -294,4 +294,40 @@ private List<ResolvedExpression>
resolveSQLFilterToExpression(
return resolver.resolve(Arrays.asList(resolvedExp));
}
+
+ private RexNodeToExpressionConverter getConverter(
+ RexBuilder rexBuilder,
+ String[] inputNames,
+ FunctionCatalog functionCatalog,
+ CatalogManager catalogManager) {
+ try {
+ Class<?> clazz =
+ Class.forName(
+
"org.apache.flink.table.planner.plan.utils.RexNodeToExpressionConverter",
+ false,
+ classLoader);
+
+ Constructor<?>[] constructors = clazz.getConstructors();
+
+ for (Constructor<?> constructor : constructors) {
+ if (constructor.getParameterCount() == 4) {
+ return (RexNodeToExpressionConverter)
+ constructor.newInstance(
+ rexBuilder, inputNames, functionCatalog,
catalogManager);
+ }
+ if (constructor.getParameterCount() == 5) {
Review Comment:
```suggestion
if (constructor.getParameterCount() == 5 &&
TimeZone.class.equals(constructor.getParameters()[4].getType())) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
