Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2870#discussion_r90496100
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarOperators.scala
 ---
    @@ -78,6 +78,69 @@ object ScalarOperators {
         }
       }
     
    +  def generateIn(
    +      nullCheck: Boolean,
    +      left: GeneratedExpression,
    +      right: scala.collection.mutable.Buffer[GeneratedExpression],
    +      addReusableCodeCallback: (String, String) => Any)
    +    : GeneratedExpression = {
    +    val resultTerm = newName("result")
    +    val isNull = newName("isNull")
    +
    +    val castNumeric = if (isNumeric(left.resultType) || 
isNumeric(right.head.resultType)) {
    +      (value: String) => s"""new java.math.BigDecimal("" + 
$value).stripTrailingZeros()"""
    --- End diff --
    
    Casting all numeric values to `BigInteger` is quite expensive. Please check 
how numeric casting is done for binary operations, e.g., in 
`generateArithmeticOperator()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to