yuxiqian commented on code in PR #3461:
URL: https://github.com/apache/flink-cdc/pull/3461#discussion_r1699466491
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/json/canal/CanalJsonSerializationSchema.java:
##########
@@ -132,6 +132,17 @@ public byte[] serialize(Event event) {
}
DataChangeEvent dataChangeEvent = (DataChangeEvent) event;
+ reuseGenericRowData.setField(
+ 3,
StringData.fromString(dataChangeEvent.tableId().getSchemaName()));
Review Comment:
`org.apache.flink.table.data.StringData#fromString` was used to generate
binary data from string here, but I noticed that
`org.apache.flink.cdc.common.data.binary.BinaryStringData#fromString` is more
frequently used in CDC code base. Though they're basically the same (CDC
version was copied from Flink), is it better if we can stick to one consistent
binary encoding algorithm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
