superdiaodiao commented on code in PR #25137:
URL: https://github.com/apache/flink/pull/25137#discussion_r1701430328
##########
docs/data/sql_functions.yml:
##########
@@ -304,7 +304,13 @@ string:
not exceed the number of the defined groups.
E.g. REGEXP_EXTRACT('foothebar', 'foo(.*?)(bar)', 2)" returns "bar".
-
+ - sql: REGEXP_EXTRACT_ALL(str, regex[, extractIndex])
+ table: str.regexpExtractAll(regex[, extractIndex])
+ description: |
+ Extracts all the strings in str that match the regex expression and
correspond to the regex group extractIndex.
+ regex may contain multiple groups. extractIndex indicates which regex
group to extract and starts from 1. 0 means matching the entire regular
expression, also the default value if not specified.
Review Comment:
Generally, `if not specified` means the parameter is missing. In other
words, if `extractIndex` equals to `null`, we should point out this case
leading to the same result according to your code. Therefore, would it better
if we change `if not specified`to `if not specified or null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
