lincoln-lil commented on code in PR #25119:
URL: https://github.com/apache/flink/pull/25119#discussion_r1703254158
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/window/WindowRankOperatorBuilder.java:
##########
@@ -116,11 +118,17 @@ public WindowRankOperatorBuilder windowEndIndex(int
windowEndIndex) {
return this;
}
+ public WindowRankOperatorBuilder isEventTime(Boolean isEventTime) {
Review Comment:
nit: `isEventTime` looks like a predicate, could we just use `with` or `set`
prefix for the set method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
