lincoln-lil commented on code in PR #25138:
URL: https://github.com/apache/flink/pull/25138#discussion_r1707101343
##########
flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/types/PojoTestUtilsTest.java:
##########
@@ -64,4 +72,20 @@ public static class Pojo {
public static class PojoRequiringKryo {
public List<Integer> x;
}
+
+ @TypeInfo(FooFactory.class)
+ public interface Foo {}
+
+ public static class FooFactory extends TypeInfoFactory<Foo> {
+ @Override
+ public TypeInformation<Foo> createTypeInfo(Type type, Map<String,
TypeInformation<?>> map) {
+ return Types.POJO(Foo.class, new HashMap<>());
+ }
+ }
+
+ @Test
+ void testPojoTypeInfoOnInterface() {
Review Comment:
Honestly, I don't think we have a mandatory placement, but the intuition to
separate the test and auxiliary classes comes from experience with the table
modules, and this test class alread does that. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
