ferenc-csaky commented on PR #25139: URL: https://github.com/apache/flink/pull/25139#issuecomment-2286027140
> Just wondering what will happen when the default is not empty list, like for example `security.module.factory.classes`? Without super deep consideration maybe we need to compare with default? This method actually has very limited usage. It is only used for setting `pipeline.classpaths` and `pipeline.jars`, because those are mapped from `URL` to `String`. (For the sake of completeness, this method is also called in `ConfigUtils#encodeArrayToConfig(...)`, but that is only used for `yarn.ship-files` and parsing the passed job args in application mode.) But regardless, if we think about this as a general util method, considering it would set back the default value when called with a nonsense (null or empty) value could be reasonable, but at this point I'd rather just change back this one bit as it is would sufficiently does what it needs at this point, as it is only used for some specific config options that does not require to deal with default values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
