robg-eb commented on code in PR #152:
URL:
https://github.com/apache/flink-connector-aws/pull/152#discussion_r1715947230
##########
flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/table/RowDataElementConverterTest.java:
##########
@@ -45,10 +48,17 @@ public class RowDataElementConverterTest {
DataTypes.FIELD("partition_key", DataTypes.STRING()),
DataTypes.FIELD("payload", DataTypes.STRING()));
private static final RowDataElementConverter elementConverter =
- new RowDataElementConverter(DATA_TYPE);
+ new RowDataElementConverter(DATA_TYPE, null);
private static final SinkWriter.Context context = new
UnusedSinkWriterContext();
private static final RowDataToAttributeValueConverter
rowDataToAttributeValueConverter =
- new RowDataToAttributeValueConverter(DATA_TYPE);
+ new RowDataToAttributeValueConverter(DATA_TYPE, null);
+
+ private static final Set<String> primaryKeys =
+ new HashSet<>(Collections.singletonList("partition_key"));
Review Comment:
Implemented these changes now.
##########
flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverterTest.java:
##########
@@ -51,7 +58,7 @@ void testChar() {
DataType dataType = DataTypes.ROW(DataTypes.FIELD(key,
DataTypes.CHAR(9)));
RowDataToAttributeValueConverter rowDataToAttributeValueConverter =
- new RowDataToAttributeValueConverter(dataType);
+ new RowDataToAttributeValueConverter(dataType, null);
Review Comment:
Thanks! Implemented that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
