mateczagany commented on code in PR #860:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1718035018
##########
docs/layouts/shortcodes/generated/dynamic_section.html:
##########
@@ -8,6 +8,24 @@
</tr>
</thead>
<tbody>
+ <tr>
+ <td><h5>kubernetes.operator.checkpoint.cleanup.enabled</h5></td>
+ <td style="word-wrap: break-word;">true</td>
+ <td>Boolean</td>
+ <td>Whether to enable clean up of checkpoint FlinkStateSnapshot
resources created by the operator automatically. This will only remove the
FlinkStateSnapshot CR, and will not remove any data on the filesystem.</td>
+ </tr>
+ <tr>
+ <td><h5>kubernetes.operator.checkpoint.history.max.age</h5></td>
+ <td style="word-wrap: break-word;">1 d</td>
+ <td>Duration</td>
+ <td>Maximum age for checkpoint FlinkStateSnapshot resources to
retain. Due to lazy clean-up, the most recent checkpoint may live longer than
the max age.</td>
+ </tr>
+ <tr>
+ <td><h5>kubernetes.operator.checkpoint.history.max.count</h5></td>
+ <td style="word-wrap: break-word;">10</td>
+ <td>Integer</td>
+ <td>Maximum number of checkpoint FlinkStateSnapshot resources to
retain.</td>
+ </tr>
Review Comment:
That sounds good. I wasn't sure how fine-grained these config options should
be, but if you think that we don't need these, I am happy to make this PR more
simple and reduce the amount of config options.
It will be very easy to add these config options back in the future if we
deem them necessary anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]