twalthr commented on code in PR #25207:
URL: https://github.com/apache/flink/pull/25207#discussion_r1719432608
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecSortLimit.java:
##########
@@ -38,21 +40,47 @@
import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
import org.apache.flink.table.types.logical.RowType;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
import java.util.Collections;
+import java.util.List;
+
+import static
org.apache.flink.table.planner.plan.nodes.exec.batch.BatchExecLimit.FIELD_NAME_IS_GLOBAL;
+import static
org.apache.flink.table.planner.plan.nodes.exec.batch.BatchExecLimit.FIELD_NAME_LIMIT_END;
+import static
org.apache.flink.table.planner.plan.nodes.exec.batch.BatchExecLimit.FIELD_NAME_LIMIT_START;
+import static
org.apache.flink.table.planner.plan.nodes.exec.batch.BatchExecSort.FIELD_NAME_SORT_SPEC;
/**
* {@link BatchExecNode} for Sort with limit.
*
* <p>This node will output data rank from `limitStart` to `limitEnd`.
*/
+@ExecNodeMetadata(
+ name = "batch-exec-sort-limit",
+ version = 1,
+ producedTransformations = BatchExecSortLimit.SORT_LIMIT_TRANSFORMATION,
+ minPlanVersion = FlinkVersion.v2_0,
+ minStateVersion = FlinkVersion.v2_0)
public class BatchExecSortLimit extends ExecNodeBase<RowData>
implements BatchExecNode<RowData>,
SingleTransformationTranslator<RowData> {
+ public static final String SORT_LIMIT_TRANSFORMATION = "sort-limit";
+
+ @JsonProperty(FIELD_NAME_SORT_SPEC)
private final SortSpec sortSpec;
+
+ @JsonProperty(FIELD_NAME_LIMIT_START)
private final long limitStart;
+
+ @JsonProperty(FIELD_NAME_LIMIT_END)
private final long limitEnd;
+
+ @JsonProperty(FIELD_NAME_IS_GLOBAL)
private final boolean isGlobal;
+ public static final String FIELD_NAME_MATCH_SPEC = "matchSpec";
Review Comment:
Move to the top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
