vahmed-hamdy commented on code in PR #157:
URL:
https://github.com/apache/flink-connector-aws/pull/157#discussion_r1723039905
##########
flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkWriterTest.java:
##########
@@ -63,6 +63,8 @@ public class DynamoDbSinkWriterTest {
private static final String PARTITION_KEY = "partition_key";
private static final String SORT_KEY = "sort_key";
+ private static final boolean isTableArn = true;
Review Comment:
We are removing all Table Name tests.
could we add tests to test cases of arn only, table name only, both.
I believe we can use `TrackingDynamoDbAsyncClient` to test it correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
