mateczagany commented on code in PR #868:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/868#discussion_r1723640077
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerTest.java:
##########
@@ -654,28 +653,6 @@ private void testSnapshotLegacy(FlinkDeployment
deployment, SnapshotType snapsho
assertTrue(isSnapshotInProgress.test(getJobStatus(snDeployment)));
assertEquals(SnapshotStatus.PENDING,
getLastSnapshotStatus(snDeployment, snapshotType));
snDeployment.getSpec().getFlinkConfiguration().put(triggerSnapshotExpression.key(),
"0");
-
Review Comment:
I have deleted this test case as I could not find a good way to update the
recorded last periodic timestamp without modifying access to the
`SnapshotTriggerTimestampStore` fields.
We already test the CRON ability by testing methods
`SnapshotUtils#shouldTriggerAutomaticSnapshot` and
`SnapshotUtils#interpretAsCron`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
