Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2915#discussion_r90664782
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlay.java
 ---
    @@ -0,0 +1,102 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.clusterframework.overlays;
    +
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.runtime.clusterframework.ContainerSpecification;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import javax.annotation.Nullable;
    +import java.io.File;
    +import java.io.IOException;
    +
    +
    +/**
    + * Overlays cluster-level Kerberos credentials (i.e. keytab) into a 
container.
    + *
    + * The folloowing Flink configuration entries are updated:
    + *  - security.keytab
    + */
    +public class KeytabOverlay extends AbstractContainerOverlay {
    +
    +   private static final Logger LOG = 
LoggerFactory.getLogger(KeytabOverlay.class);
    +
    +   static final Path TARGET_PATH = new Path("krb5.keytab");
    +
    +   final Path keytab;
    +
    +   public KeytabOverlay(@Nullable File keytab) {
    +           this.keytab = keytab != null ? new Path(keytab.toURI()) : null;
    +   }
    +
    +   public KeytabOverlay(@Nullable Path keytab) {
    +           this.keytab = keytab;
    +   }
    +
    +   @Override
    +   public void configure(ContainerSpecification container) throws 
IOException {
    +           if(keytab != null) {
    +                   
container.getArtifacts().add(ContainerSpecification.Artifact.newBuilder()
    +                           .setSource(keytab)
    +                           .setDest(TARGET_PATH)
    +                           .setCachable(false)
    +                           .build());
    +                   
container.getDynamicConfiguration().setString(ConfigConstants.SECURITY_KEYTAB_KEY,
 TARGET_PATH.getPath());
    +           }
    +   }
    +
    +   public static Builder newBuilder() {
    +           return new Builder();
    +   }
    +
    +   /**
    +    * A builder for the {@link HadoopUserOverlay}.
    +    */
    +   public static class Builder {
    +
    +           File keytabPath;
    +
    +           /**
    +            * Configures the overlay using the current environment (and 
global configuration).
    +            *
    +            * The following Flink configuration settings are checked for a 
keytab:
    +            *  - security.keytab
    +         */
    --- End diff --
    
    indention is off here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to