ferenc-csaky commented on code in PR #874:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/874#discussion_r1738366382
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/spec/JobSpec.java:
##########
@@ -100,9 +92,8 @@ public class JobSpec implements Diffable<JobSpec> {
/**
* Nonce used to trigger a full redeployment of the job from the savepoint
path specified in
- * initialSavepointPath or the path/FlinkStateSnapshot reference in
flinkStateSnapshotReference.
- * In order to trigger redeployment, change the number to a different
non-null value. Rollback
- * is not possible after redeployment.
+ * initialSavepointPath.In order to trigger redeployment, change the
number to a different
Review Comment:
nit: "initialSavepointPath.In order" -> "initialSavepointPath. In order"
##########
docs/content/docs/custom-resource/reference.md:
##########
@@ -188,11 +176,10 @@ This serves as a full reference for FlinkDeployment and
FlinkSessionJob custom r
| state | org.apache.flink.kubernetes.operator.api.spec.JobState | Desired
state for the job. |
| savepointTriggerNonce | java.lang.Long | Nonce used to manually trigger
savepoint for the running job. In order to trigger a savepoint, change the
number to a different non-null value. |
| initialSavepointPath | java.lang.String | Savepoint path used by the job the
first time it is deployed or during savepoint redeployments (triggered by
changing the savepointRedeployNonce). |
-| flinkStateSnapshotReference |
org.apache.flink.kubernetes.operator.api.spec.FlinkStateSnapshotReference |
Snapshot reference used by the job the first time it is deployed or during
savepoint redeployments (triggered by changing the savepointRedeployNonce). |
| checkpointTriggerNonce | java.lang.Long | Nonce used to manually trigger
checkpoint for the running job. In order to trigger a checkpoint, change the
number to a different non-null value. |
| upgradeMode | org.apache.flink.kubernetes.operator.api.spec.UpgradeMode |
Upgrade mode of the Flink job. |
| allowNonRestoredState | java.lang.Boolean | Allow checkpoint state that
cannot be mapped to any job vertex in tasks. |
-| savepointRedeployNonce | java.lang.Long | Nonce used to trigger a full
redeployment of the job from the savepoint path specified in
initialSavepointPath or the path/FlinkStateSnapshot reference in
flinkStateSnapshotReference. In order to trigger redeployment, change the
number to a different non-null value. Rollback is not possible after
redeployment. |
+| savepointRedeployNonce | java.lang.Long | Nonce used to trigger a full
redeployment of the job from the savepoint path specified in
initialSavepointPath.In order to trigger redeployment, change the number to a
different non-null value. Rollback is not possible after redeployment. |
Review Comment:
nit: "initialSavepointPath.In" -> "\`initialSavepointPath`. In"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
