gyfora commented on code in PR #875:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/875#discussion_r1738642261
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -156,6 +159,9 @@ public boolean scaleResource(
autoScalerStateStore.storeConfigChanges(context, configOverrides);
+ // Try to clear all delayed scale down requests after scaling.
+ delayedScaleDown.clearAll();
Review Comment:
So if there was a scale down before 9:00 and that set the first trigger
time, that doesn't matter as the scale up resets it subsequently.
In that case we should probably rename the method `
detectImmediateScaleDown` to something like `applyScaleDownInterval`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
