syhily commented on code in PR #95:
URL:
https://github.com/apache/flink-connector-pulsar/pull/95#discussion_r1739584384
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarPartitionSplitReader.java:
##########
@@ -196,7 +197,14 @@ public void
handleSplitsChanges(SplitsChange<PulsarPartitionSplit> splitsChanges
MessageId latestConsumedId = registeredSplit.getLatestConsumedId();
if (latestConsumedId != null) {
- LOG.info("Reset subscription position by the checkpoint {}",
latestConsumedId);
+ if (latestConsumedId instanceof BatchMessageIdImpl) {
Review Comment:
So. I think there is no need to cast to `BatchMessageIdImpl`. Slf4j will
print the log by calling the toString method. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
