davidradl commented on PR #25275: URL: https://github.com/apache/flink/pull/25275#issuecomment-2324323902
Hi, Please follow [https://flink.apache.org/how-to-contribute/contribute-code/](https://flink.apache.org/how-to-contribute/contribute-code/ ). There should be a discussion first then a Jira prior to the pr. On the code: - It looks like you have added functions to a utility class that are not being called from anywhere, so this is dead code, until you add callers. The discussion would hopefully cover this. - there is no Apache license at the top of the files - there are no junit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
