[ 
https://issues.apache.org/jira/browse/FLINK-36201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878729#comment-17878729
 ] 

Rui Fan commented on FLINK-36201:
---------------------------------

Hey [~roman]  [~dmvk] , would you mind taking a look this Jira in your free 
time? thanks~

Please correct me if I missed some background, I could fix it if you think it 
makes sense.

cc [~mapohl] , the active contributor of Adaptive Scheduler for now.

> StateLocalitySlotAssigner should be only used when local recovery is enabled 
> for Adaptive Scheduler
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-36201
>                 URL: https://issues.apache.org/jira/browse/FLINK-36201
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>            Reporter: Rui Fan
>            Priority: Major
>
> SlotSharingSlotAllocator created the StateLocalitySlotAssigner[1] instead of 
> DefaultSlotAssigner when failover happens.
> I'm curious why we use StateLocalitySlotAssigner when local recovery is 
> disable. As I understand, StateLocalitySlotAssigner  should be only used when 
> local recovery is enable. If we don't backup state on the TM local disk, the 
> local recovery doesn't take effect.
>  
> [1] 
> https://github.com/apache/flink/blob/c869326d089705475481c2c2ea42a6efabb8c828/flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java#L136



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to