[
https://issues.apache.org/jira/browse/FLINK-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719833#comment-15719833
]
ASF GitHub Bot commented on FLINK-5246:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2930#discussion_r90775412
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1376,6 +1376,24 @@ class JobManager(
// addressed to the periodic checkpoint coordinator.
log.info("Received message for non-existing checkpoint
" +
ackMessage.getCheckpointId)
+
+ val classLoader =
Option(libraryCacheManager.getClassLoader(jid)) match {
+ case Some(userCodeClassLoader) => userCodeClassLoader
+ case None => getClass.getClassLoader
+ }
+
+ future {
+ Option(ackMessage.getState()) match {
--- End diff --
Should we check the option before submitting the future and only do it if
it's non empty?
> Don't discard unknown checkpoint messages in the CheckpointCoordinator
> ----------------------------------------------------------------------
>
> Key: FLINK-5246
> URL: https://issues.apache.org/jira/browse/FLINK-5246
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.1.4
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.1.4
>
>
> The delicate interplay of the {{CheckpointCoordinator}} and the
> {{SavepointCoordinator}} requires that unknown checkpoint messages are not
> discarded but given to the other coordinator. If both coordinator don't
> accept the checkpoint message, then the associated state will be discarded by
> the {{JobManager}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
