Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r90777407
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamMockEnvironment.java
---
@@ -215,6 +189,31 @@ public Void answer(InvocationOnMock invocationOnMock)
throws Throwable {
}
}
+ private <T> void
addBufferToOutputList(RecordDeserializer<DeserializationDelegate<T>>
recordDeserializer,
+
NonReusingDeserializationDelegate<T> delegate, Buffer buffer,
--- End diff --
In test scope, this is not a problem, but in main scope the style
guidelines (and check style plugin) do not allow leading whitespace.
Personally, I don't think it's good practice to differentiate between tests and
main code. You might consider removing the leading space here, too (for example
one argument per line).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
