[
https://issues.apache.org/jira/browse/FLINK-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719995#comment-15719995
]
ASF GitHub Bot commented on FLINK-5059:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r90777407
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamMockEnvironment.java
---
@@ -215,6 +189,31 @@ public Void answer(InvocationOnMock invocationOnMock)
throws Throwable {
}
}
+ private <T> void
addBufferToOutputList(RecordDeserializer<DeserializationDelegate<T>>
recordDeserializer,
+
NonReusingDeserializationDelegate<T> delegate, Buffer buffer,
--- End diff --
In test scope, this is not a problem, but in main scope the style
guidelines (and check style plugin) do not allow leading whitespace.
Personally, I don't think it's good practice to differentiate between tests and
main code. You might consider removing the leading space here, too (for example
one argument per line).
> only serialise events once in RecordWriter#broadcastEvent
> ---------------------------------------------------------
>
> Key: FLINK-5059
> URL: https://issues.apache.org/jira/browse/FLINK-5059
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> Currently,
> org.apache.flink.runtime.io.network.api.writer.RecordWriter#broadcastEvent
> serialises the event once per target channel. Instead, it could serialise the
> event only once and use the serialised form for every channel and thus save
> resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
