fredia commented on code in PR #24812:
URL: https://github.com/apache/flink/pull/24812#discussion_r1744777781
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStDBGetRequest.java:
##########
@@ -45,6 +47,12 @@ public abstract class ForStDBGetRequest<K, N, V, R> {
this.future = future;
}
+ public void process(RocksDB db) throws IOException, RocksDBException {
Review Comment:
The `process()` functions of `ForStDBPutRequest` , `ForStDBGetRequest` and
`ForStDBIterRequest` have different parameters, it is not convenient to
summarize then with a generic interface, I think it is better to keep it as it
is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
