akatona84 commented on code in PR #117:
URL:
https://github.com/apache/flink-connector-kafka/pull/117#discussion_r1745650526
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/subscriber/KafkaSubscriberUtils.java:
##########
@@ -38,6 +40,19 @@ static Map<String, TopicDescription>
getAllTopicMetadata(AdminClient adminClient
}
}
+ static Map<String, TopicDescription> getTopicMetadata(AdminClient
adminClient, Pattern topicPattern) {
+ try {
+ Set<String> allTopicNames = adminClient.listTopics().names().get();
+ Set<String> patternTopicNames = allTopicNames.stream()
Review Comment:
nit: matchedTopic* would sound nicer than patternTopic* (not just here, in
the whole pr)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
