hlteoh37 commented on code in PR #163:
URL:
https://github.com/apache/flink-connector-aws/pull/163#discussion_r1750112355
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/util/ShardUtils.java:
##########
@@ -26,7 +26,10 @@
/** Utility methods for properties of DynamoDB streams shards. */
@Internal
public class ShardUtils {
- private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD =
Duration.ofHours(25);
+ private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD =
Duration.ofHours(48);
+
+ private static final Duration
DDB_STREAMS_MAX_RETENTION_PERIOD_FOR_RESOLVING_INCONSISTENCIES =
Review Comment:
can we add a comment to explain why this is different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
