snuyanzin commented on code in PR #25312: URL: https://github.com/apache/flink/pull/25312#discussion_r1754991610
########## flink-table/flink-table-planner/src/main/java/org/apache/calcite/rex/RexFieldAccess.java: ########## @@ -49,6 +49,12 @@ * AND gender = 'F')</pre> * * </blockquote> + * + * <p>FLINK modifications are at lines + * + * <ol> + * <li>Should be removed after fixing CALCITE-6342 (Calcite 1.36.0): Lines 84-89 Review Comment: usually in such headers we put what is the difference between current version of class and the original Calcite one. Since currently there is only one diff which should disappear together with upgrade to 1.36 then after upgrade this file will be identical to the one from Calcite => could be removed unless for some reason more discrepancies appear... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
