hlteoh37 commented on code in PR #164:
URL:
https://github.com/apache/flink-connector-aws/pull/164#discussion_r1756892805
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java:
##########
@@ -159,12 +170,35 @@ public boolean isAssigned(String splitId) {
return assignedSplits.contains(splitId);
}
+ /**
+ * Function to get children splits available for given parent ids. This
will ensure not to
+ * iterate all the values in knownSplits so saving compute
+ */
+ public List<DynamoDbStreamsShardSplit> splitsAvailableForAssignment(
Review Comment:
Let's also add some unit tests for these public methods!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
