zentol commented on code in PR #25250:
URL: https://github.com/apache/flink/pull/25250#discussion_r1760835206
##########
flink-python/src/test/java/org/apache/flink/streaming/api/utils/ProtoUtilsTest.java:
##########
@@ -82,7 +80,7 @@ void testParseStateTtlConfigFromProto() {
.build();
FlinkFnApi.StateDescriptor.StateTTLConfig stateTTLConfigProto =
FlinkFnApi.StateDescriptor.StateTTLConfig.newBuilder()
- .setTtl(Time.of(1000,
TimeUnit.MILLISECONDS).toMilliseconds())
+ .setTtl(1000)
Review Comment:
side-note: urgh, why is the builder using different units and names then the
StateTTLConfig getter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
