[
https://issues.apache.org/jira/browse/FLINK-5261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722229#comment-15722229
]
ASF GitHub Bot commented on FLINK-5261:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2944
[FLINK-5261] Clean up meters in ScheduledDropwizardReporter
This PR fixes the metric-cleanup in the `ScheduledDropwizardReporter`. We
were missing a separate branch for meters within `notifyOfRemovedMetric`.
I've also added a test case to make sure that all metric types are properly
cleaned up, both on our and and from the Dropwizard registry.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 5261_meter_cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2944
----
commit b45795a7cfd0a27699f0a5e23d1b966b154afdf1
Author: zentol <[email protected]>
Date: 2016-12-05T13:00:10Z
[FLINK-5261] Clean up meters in ScheduledDropwizardReporter
----
> ScheduledDropwizardReporter does not properly clean up metrics
> --------------------------------------------------------------
>
> Key: FLINK-5261
> URL: https://issues.apache.org/jira/browse/FLINK-5261
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.2.0, 1.1.4
>
>
> The ScheduleDropWizardReporter does not have a separate branch for meters in
> notifyOfRemovedMetric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
